Invision Power Services > Patch: Avatar Gallery Dropdown and RSS Order

Help - Search - Members - Calendar

Full Version: Patch: Avatar Gallery Dropdown and RSS Order

Invision Power Services > Invision Power Services, Inc. > IPS Company Feedback > IP.Board

frame

Jul 14 2006, 08:49 PM

Hiya,

I wanted to post this for a long time, today is the day:

1. Avatar Gallery Dropdown fix

Make the Dropdown keep it's selection when a new gallery is picked:

CODE

--- sources/action_public/usercp.php (v2.1.7)
@@ -2790,9 +2790,9 @@

    $av_gals = "<select name='av_cat' class='forminput'>\n";

    foreach( $av_categories as $cat )
    {
-     $av_gals .= "<option value='".$cat[0]."'>".$cat[1]."</option>\n";
+     $av_gals .= "<option value='".$cat[0]."'".($cat[0] == urlencode($av_cat_selected)?' selected':'').">".$cat[1]."</option>\n";
    }

    $av_gals .= "</select>\n";

2. Maintain the RSS-Export order as defined in ACP

If you define more than just one RSS feed to be exported from your website the order of the Feed is critical to define: Firefox only can 'subscribe' to the first feed, so do most browsers which detect embedded RSS support.

The following fix here puts the feeds in the order you define.

Note: you need to rebuild the RSS cache at the ACP in order to see your changes.

CODE

--- sources/action_admin/rssexport.php (v2.1.7)
@@ -150,7 +150,7 @@
    // Go loopy
    //--------------------------------------------

-   $this->ipsclass->DB->build_query( array( 'select' => '*', 'from' => 'rss_export' ) );
+   $this->ipsclass->DB->build_query( array( 'select' => '*', 'from' => 'rss_export', 'order' => 'rss_export_id' ) );
    $outer = $this->ipsclass->DB->exec_query();

    while( $row = $this->ipsclass->DB->fetch_row( $outer ) )

I hope both patches make it into the next release, since they are quite simple to integrate and fix two minor annoyances (well, for me they do

.

best,
frame

Digi

Jul 14 2006, 09:57 PM

I've never had any issues with FF and the IPB rss button @ the bottom of the forums. I have always been able to choose what ever feed I wanted to subscribe to.

Unless you are talking about the tool bar version of rss links or something....

frame

Jul 14 2006, 10:02 PM

Hiya,

It's only about the order.. for both, Live-Bookmarks and the RSS-Button at the bottom of the board.

The ACP supports to order them (e.g. Corporate News first), the forum doesn't.

best,
frame

edit: at my first post I do indeed claim that FF only supports one feed, that's not true since.. well 1.5 .. i think??

This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.